-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4주차] 우리 동네 맥주집 컴컴온 #5
Open
aeuna
wants to merge
11
commits into
main
Choose a base branch
from
week4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for stately-semifreddo-57c531 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
오늘도 할할놀놀을 몸소 실천 중인 웹파트원 ! 화이팅 :) |
스켈레톤 이뿌요 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 구현 기능 명세
**두가지**
의 기능을 제공해요Geolocation API
를 통해서 현재 위치의 위도와 경도 정보를 얻어와요.=> getLocation()
카카오 로컬 API
의 param으로 전달하여 위치기반 맥주집 리스트들을 보여줘요.=> getMyLocationPub()
=> getSpecificLocationPub()
disabled
시켜주세요.=> checked 상태를 두어서, 내 지역 기반 인지 키워드 기반인지 판단해주고, disabled={checked} 이런식으로 처리했습니당
=> 삼항연산자 사용해서, 결과가 없어요가 뜨도록 했습니다
공통
: 가게 이름, 전화번호, 카카오맵에서의 해당 가게 링크 (가게이름 클릭시 링크로 이동하도록)지역기반 검색
: 현재 나로부터의 위치특정위치 검색
: 해당 가게의 주소=> 데이터 가져올때, 가져오고 싶은 정보만 가져오도록 가공하는 함수(getPubInfoList) 사용했어요!
Loading
중임을 나타내는 UI를 보여주세요.=> 6번으로 스켈레톤 UI 만들었습니당
🎁 PR Point
😭 어려웠던 점
은근히 비동기 동작 방식이 파악하기가 어려웠어요! promise에 대해서 자료를 더 찾아서 공부해봐야 할 것 같습니다! ㅎㅎ
로딩 표시해줄 때 항상 이미지 하나 가져와서 돌려주는 방식으로만 했었는데, 스켈레톤 UI 사용해보니까 UI 구성적으로 더 좋은 것 같습니당
😎 구현 결과물
https://stately-semifreddo-57c531.netlify.app/