Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CICD Tests #96

Merged
merged 5 commits into from
Aug 22, 2024
Merged

CICD Tests #96

merged 5 commits into from
Aug 22, 2024

Conversation

markspec
Copy link
Collaborator

Update CICD pipeline to:

  • build tests
  • run tests

If tests run this will resolve #14

This can only be tested by creating a PR

@markspec markspec linked an issue Aug 20, 2024 that may be closed by this pull request
Run unit tests #14
Closed
BrianMichell
BrianMichell reviewed Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@BrianMichell BrianMichell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The acceptance test currently runs our limited Python compatibility regression testing. We will need to make the zarr and xarray Python modules available before the tests will pass.

.github/workflows/cmake_build.yaml Outdated Show resolved Hide resolved
@markspec
Copy link
Collaborator Author

@BrianMichell , please can you fix the failing tests/

BrianMichell
BrianMichell approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@BrianMichell BrianMichell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrianMichell BrianMichell merged commit 089ad3e into TGSAI:main Aug 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianMichell BrianMichell BrianMichell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run unit tests
2 participants
@markspec @BrianMichell