Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mdio::utils::DeleteDataset more secure #76

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Make mdio::utils::DeleteDataset more secure #76

merged 3 commits into from
Aug 12, 2024

Conversation

BrianMichell
Copy link
Collaborator

@BrianMichell BrianMichell commented Aug 6, 2024 •
edited
Loading

Resolves #25
Closes #38 without merging

  • Removes calls to std::system and std::filesystem. This should be far more secure and robust.

@BrianMichell BrianMichell added the Improvement Something could be better label Aug 6, 2024
@BrianMichell BrianMichell requested a review from blasscoc August 6, 2024 19:15
@markspec markspec merged commit 59ef2a2 into main Aug 12, 2024
6 checks passed
@markspec markspec deleted the 25_delete_by_kvs branch August 12, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markspec markspec markspec approved these changes

@blasscoc blasscoc Awaiting requested review from blasscoc

Assignees
No one assigned
Labels
Improvement Something could be better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make DeleteDataset more robust and secure
2 participants
@BrianMichell @markspec