Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added getter for attributesAddress #56

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Added getter for attributesAddress #56

merged 1 commit into from
Jul 31, 2024

Conversation

BrianMichell
Copy link
Collaborator

Resolves #47

@BrianMichell BrianMichell requested a review from blasscoc July 31, 2024 15:33
blasscoc
blasscoc approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@blasscoc blasscoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's a member function, this gives const access to the attributeAddress

which won't get destroyed in the life cycle of the object.

@blasscoc blasscoc merged commit 7b5ea31 into main Jul 31, 2024
6 checks passed
@blasscoc blasscoc deleted the 47_variable_warning branch July 31, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blasscoc blasscoc blasscoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suppress warning Variable.h
2 participants
@BrianMichell @blasscoc