Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect internal handling of dimension size type #140

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Fix incorrect internal handling of dimension size type #140

merged 3 commits into from
Nov 13, 2024

Conversation

BrianMichell
Copy link
Collaborator

@BrianMichell BrianMichell commented Oct 23, 2024 •
edited
Loading

Resolves #139
Closes #138 due to not branching off main for this PR.

@BrianMichell BrianMichell added the bug Something isn't working label Oct 23, 2024
@BrianMichell BrianMichell requested a review from markspec October 23, 2024 14:42
markspec
markspec approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@markspec markspec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markspec markspec merged commit 9e21705 into main Nov 13, 2024
6 checks passed
@markspec markspec deleted the 139_max_size branch November 13, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markspec markspec markspec approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maximum size for stores is incorrect
2 participants
@BrianMichell @markspec