Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix structured data metadata only trim #132

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

BrianMichell
Copy link
Collaborator

Resolves #131
No longer requires structured data to select a field and resolves bug causing non-OK status if not used with the true flag for delete_sliced_out_chunks.

@BrianMichell BrianMichell added the bug Something isn't working label Oct 17, 2024
@BrianMichell BrianMichell requested a review from markspec October 17, 2024 19:57
Copy link
Collaborator

@markspec markspec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markspec markspec merged commit 0771808 into main Oct 22, 2024
6 checks passed
@markspec markspec deleted the 131_Trim_struct_metadata branch October 22, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TrimDataset utility function doesn't behave properly with structured data
2 participants