Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added getters for Variable rank #129

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Added getters for Variable rank #129

merged 1 commit into from
Oct 22, 2024

Conversation

BrianMichell
Copy link
Collaborator

Resolves #127

@BrianMichell BrianMichell added the Improvement Something could be better label Oct 10, 2024
markspec
markspec approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@markspec markspec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@markspec markspec merged commit 7b20658 into main Oct 22, 2024
6 checks passed
@markspec markspec deleted the 127_rank_getter branch October 22, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markspec markspec markspec approved these changes

Assignees
No one assigned
Labels
Improvement Something could be better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add clean getter for rank in Variable and VariableData
2 participants
@BrianMichell @markspec