Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Github CI packages #1499

Closed
wants to merge 4 commits into from
Closed

Conversation

WaDadidou
Copy link
Collaborator

@WaDadidou WaDadidou commented Feb 5, 2025

Issues

Github CI

upload-artifact:
https://github.com/TERITORI/teritori-dapp/actions/runs/13163113075/job/36736588553?pr=1477

download-artifact:
https://github.com/TERITORI/teritori-dapp/actions/runs/13163523128/job/36739590851?pr=1499

Expo

ExpoBlur:
https://github.com/TERITORI/teritori-dapp/actions/runs/13163523126/job/36737981317?pr=1499
expo/expo#34141

So, npx expo install --check to check and update Expo deps.

Some deps updated to enhance compability, following this warning:

The following packages should be updated for best compatibility with the installed expo version:
  @babel/[email protected] - expected version: ^7.25.2
  @types/[email protected] - expected version: ~18.3.12
  [email protected] - expected version: ~5.0.11

About expo stuff, run npx expo-doctor to check the deps

Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for gno-dapp failed.

Name Link
🔨 Latest commit e343b77
🔍 Latest deploy log https://app.netlify.com/sites/gno-dapp/deploys/67a3e7734f1b2b00078a19e8

Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for teritori-dapp failed.

Name Link
🔨 Latest commit e343b77
🔍 Latest deploy log https://app.netlify.com/sites/teritori-dapp/deploys/67a3e773b80de400080199d0

@WaDadidou WaDadidou self-assigned this Feb 5, 2025
@WaDadidou WaDadidou changed the title fix: Update upload-artifact to v4 because deprecated v3 fix: Update Gitthub CI packages Feb 5, 2025
@WaDadidou WaDadidou changed the title fix: Update Gitthub CI packages fix: Update Github CI packages Feb 5, 2025
@WaDadidou WaDadidou force-pushed the fix-update-ci-github-package branch from 3f90803 to 1a6d036 Compare February 5, 2025 18:34
"expo-font": "~11.10.3",
"expo-image-picker": "^14.7.1",
"expo-linear-gradient": "~12.7.2",
"expo": "latest",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need this? I think only syncing explo-blur should be okay
I any case we shouldn't change the expo version without doing the proper update walkthrough

Copy link
Collaborator Author

@WaDadidou WaDadidou Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a mistake
(I converted the PR to draft ^^)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I strongly suggest to revert all the js change and start fresh, you shouldn't need to update any typescript code

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes T_T

@WaDadidou WaDadidou marked this pull request as draft February 5, 2025 22:35
@WaDadidou WaDadidou closed this Feb 5, 2025
@WaDadidou WaDadidou deleted the fix-update-ci-github-package branch February 5, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants