feat(launchpad): Use DAO Proposal Single contract address in nft-launchpad contract config #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gno-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
WaDadidou
changed the title
WaDadidou
force-pushed
the
feat-contract-nft-launchpad-dao-proposal
branch
from
303441e to
16add6e
Compare
…chpad contract config
WaDadidou
force-pushed
the
feat-contract-nft-launchpad-dao-proposal
branch
from
16add6e to
3d47178
Compare
- Create admin DAO at nft-launchpad instantiation - Add missing functions to deployTeritoriEcosystem - Reorganize scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP zone in the code
teritori-dapp/rust/cw-contracts/nft-launchpad/src/contract.rs
Lines 162 to 163 in c7b5375
Why this PR ?
This flow is bad: https://github.com/TERITORI/teritori-dapp/blob/feat/cosmwasm-launchpad/packages/hooks/launchpad/useProposeApproveProject.ts#L29-L112
The front must not create a proposal. Also, there is too much back-and-forth between nft-launchpad contract, front and indexer.
The good way is to have the nft-launchpad contract as entry point for project approbation.
Also, the proposal must be created when the project is ready for review. The user don't have to create manually the proposal.
Then, indexer logic can be triggered from the nft-launchpad contract logic. This flow must be agnostic regarding to the front.
So, we'll execute DAO stuff from nft-launchpad contract. To do that, we'll need to store the DAO contract in the nft-launchpad contract config.
The DAO contract used to make the proposal is the Proposal Single one: https://github.com/DA0-DA0/dao-contracts/tree/development/contracts/proposal/dao-proposal-single
So, I've updated:
update_merkle_rootlogic. This is the place where to trigger the proposal creationproposal_idis emitted and will be stored in DBCosmWasmNFTLaunchpadfeatureTAKE ATTENTION TO packages/scripts/network-setup/NftLaunchpad/deployNftLaunchpad.ts
Current state
npx tsx packages/scripts/network-setup/nft-launchpad/deployNftLaunchpadScript.ts teritori-testnet testnet-adm --keyring-backend testgives me
[esbuild Error]: Unexpected "typeof" at /home/dadidou/DEV/teritori-dapp/node_modules/react-native/index.js:14:7