[Feat/#72] 예매 조회 페이지 추가 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feat/#72/Lookup
Closed
5 tasks
|
PR 작성하느라 고생 많았어요!! 라벨 잘 지정되었는지 확인 한 번 해 주기 🫶 |
pepperdad
approved these changes
Jul 11, 2024
|
|
||
| import { LookupProps } from "../types/lookupType"; | ||
|
|
||
| const LookupWrapper = ({ handleBtn, ...item }: LookupProps) => { |
There was a problem hiding this comment.
p4) 저번 코드에서는 ...rest였는데, 이번엔 왜 item 인가요? rest로 통일 되었으면 좋겠습니다!
There was a problem hiding this comment.
일반적으로 넘겨주는 props들은 ...rest로 넘기고 API를 받아오는 부분은 ...item으로 넘기고 있습니다!
ocahs9
approved these changes
Jul 12, 2024
|
|
||
| import { LookupProps } from "../types/lookupType"; | ||
|
|
||
| const LookupWrapper = ({ handleBtn, ...item }: LookupProps) => { |
| {lookUpList.length ? ( | ||
| <> | ||
| {lookUpList.map((item) => ( | ||
| <React.Fragment key={item.bookingId}> |
There was a problem hiding this comment.
<></> 가 아닌 fragment를 직접 사용한 이유가 있나요?
<> 안에는 key prop을 줄 수 없어서인가요?
There was a problem hiding this comment.
맞습니다!! map을 돌려서 key prop를 주고 싶었는데 빈 태그에는 줄 수 없어서 이렇게 작성했어요!
|
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈번호
🎟️ PR 유형
어떤 변경 사항이 있나요?
✅ Key Changes
📢 To Reviewers
Lookup.tsx에 import된 dummyData가 있고, 빈 배열의 dummyData가 있는데 이는 분기 처리를 테스트하기 위함입니다!
-> 예매한 공연 없는 경우 경우 빈 배열 주석 풀고 import 주석
-> 예매한 공연 있는 경우 import 주석 풀고 빈 배열 주석
-> 이 부분은 API 연결하면 삭제하도록 하겠습니다!
-> 현재 dummyData가 lookup 폴더 내에 있는데 API 연결하면 지울 예정이라 임시로 두었습니다.
📸 스크린샷
🔗 참고 자료