[Refactor/#82] TextField, TextArea 리팩토링 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR 작성하느라 고생 많았어요!! 라벨 잘 지정되었는지 확인 한 번 해 주기 🫶 |
sinji2102
approved these changes
Jul 10, 2024
imddoy
reviewed
Jul 10, 2024
Comment on lines
85
to
86
| </S.TextFieldWrapper> | ||
| {maxLength && cap && <S.TextCap>{`${(value as string).length}/${maxLength}`}</S.TextCap>} | ||
| {maxLength && <S.TextCap>{`${(value as string).length}/${maxLength}`}</S.TextCap>} |
There was a problem hiding this comment.
p3) 이 부분 제가 cap 여부 조건 추가해서 머지했는데 혹시 pull 받고 확인가능할까요??
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈번호
🎟️ PR 유형
어떤 변경 사항이 있나요?
✅ Key Changes
📢 To Reviewers
📸 스크린샷
🔗 참고 자료
https://jiwoothejay.notion.site/Input-a2541f69469a438ab6be1d20ab7d473c?pvs=25