Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix/#60] 모달 외부 영역 클릭시, 모달 닫는 로직 추가 #62

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

pepperdad
Copy link
Member

📌 관련 이슈번호

🎟️ PR 유형

어떤 변경 사항이 있나요?

  • 새 기능 추가
  • 버그 수정
  • CSS 등 사용자 UI 디자인 변경
  • 리팩토링

✅ Key Changes

이번 PR에서 작업한 내용을 간략히 설명해주세요

  1. 모달 외부 영역 클릭시, 모달 닫는 로직 추가

📢 To Reviewers

  • 이전과 사용법은 동일합니다! 모달 외부 영역 클릭시, 모달 닫는 로직 추가하였습니다.

📸 스크린샷

Screen.Recording.2024-07-08.at.10.18.08.PM.mov

🔗 참고 자료

@github-actions github-actions bot requested review from imddoy, ocahs9 and sinji2102 July 8, 2024 13:18
@github-actions github-actions bot added 🐛 BUG 버그를 고친 경우 ✨ FEAT 기능 구현 labels Jul 8, 2024
Copy link

github-actions bot commented Jul 8, 2024

PR 작성하느라 고생 많았어요!! 라벨 잘 지정되었는지 확인 한 번 해 주기 🫶

Copy link

sonarqubecloud bot commented Jul 8, 2024

Copy link

github-actions bot commented Jul 8, 2024

Copy link
Contributor

@sinji2102 sinji2102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

바텀시트 모달 닫는 거 구현할 때 도움 많이 됐습니다,,, 확실히 제 코드보다 와방 깔끔하네요!! 고생하셨습니다~~

@@ -4,7 +4,7 @@ export const ModalWrapper = styled.div`
position: fixed;
top: 0;
left: 0;
z-index: 100;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5) 100 진짜예요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋ 🤣

Copy link
Contributor

@imddoy imddoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아용

@pepperdad pepperdad merged commit 2c767b3 into develop Jul 9, 2024
10 checks passed
@sinji2102 sinji2102 deleted the fix/#60/ModalClose branch December 16, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 BUG 버그를 고친 경우 ✨ FEAT 기능 구현
Projects
Status: 🎉Done
Development

Successfully merging this pull request may close these issues.

[ Bug ] 모달 백그라운드 클릭시, 모달 닫도록 수정
3 participants