[Feat/#53] Stepper 공통 컴포넌트 추가 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR 작성하느라 고생 많았어요!! 라벨 잘 지정되었는지 확인 한 번 해 주기 🫶 |
sinji2102
approved these changes
Jul 7, 2024
ocahs9
approved these changes
Jul 8, 2024
pepperdad
approved these changes
Jul 8, 2024
Comment on lines
4
to
10
| export interface StepperProps { | ||
| max: number; | ||
| round: number; | ||
| setRound: (round: number) => void; | ||
| } | ||
|
|
||
| const Stepper = ({ round, max, setRound }: StepperProps) => { |
There was a problem hiding this comment.
p3) setState 자체를 props로 넘기면 안된다? 와 관련해서 화랑이가 적은 아티클이 있어서 링크 남겨놓겠습니다!
props로 onMinusClick, onPlusClick 이렇게 넘기는 방식은 어떨까요!?
There was a problem hiding this comment.
넵!! onMinusClick, onPlusClick으로 prop 넘기는 방향으로 수정했습니다!!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈번호
🎟️ PR 유형
어떤 변경 사항이 있나요?
✅ Key Changes
📢 To Reviewers
의견 마구마구 부탁드립니당.
📸 스크린샷
🔗 참고 자료
https://jinist.tistory.com/365
솔직히 svg 잘 모릅니다..ㅎ 그래서 이거 블로그보면서 색 변경해줬어용