Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/#443] 예매자 관리 페이지 퍼블리싱 #452

Merged
merged 15 commits into from
Dec 5, 2024

Conversation

sinji2102
Copy link
Contributor

📌 관련 이슈번호

🎟️ PR 유형

어떤 변경 사항이 있나요?

  • 새 기능 추가
  • 버그 수정
  • CSS 등 사용자 UI 디자인 변경
  • 리팩토링

✅ Key Changes

  1. 예매자 관리 페이지 퍼블리싱

📢 To Reviewers

준혁 오빠 코드 다.... 사라지고 처음부터 다시 짯습니당............. 어디까지가 퍼블리싱의 영역인지 모르겠어서 뭔가 오묘하게 기능이 있는 듯 없는 듯 한데 기능 추가 바로 할게요!!

📸 스크린샷

사진 내일 넣을게여 죄송해요 ㅠㅠ

@sinji2102 sinji2102 linked an issue Nov 25, 2024 that may be closed by this pull request
@github-actions github-actions bot added the ✨ FEAT 기능 구현 label Nov 25, 2024
Copy link

PR 작성하느라 고생 많았어요!! 라벨 잘 지정되었는지 확인 한 번 해 주기 🫶

Copy link
Member

@pepperdad pepperdad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

신지 최고띠

Comment on lines +171 to +191
const actions = {
PAYMENT: {
text: "입금 처리하기",
// TODO : 예매 확정 팝업
action: console.log("입금 처리"),
},
REFUND: {
text: "환불 처리하기",
// TODO : 환불 처리 팝업
action: () => console.log("환불"),
},
DELETE: {
text: "예매자 삭제하기",
// TODO : 예매자 삭제 팝업
action: () => console.log("예매자 삭제"),
},
DEFAULT: {
text: "예매자 관리하기",
action: () => setOpenMenu(true),
},
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p4: 👍

Comment on lines +214 to +220
const handleFilter = () => {
if (!openFilter) {
setOpenFilter(true);
} else {
setOpenFilter(false);
}
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p4:

Suggested change
const handleFilter = () => {
if (!openFilter) {
setOpenFilter(true);
} else {
setOpenFilter(false);
}
};
const handleFilter = () => {
setOpenFilter((prev) => !prev);
};

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#454 PR에서 반영하겠습니다!

Copy link

sonarqubecloud bot commented Dec 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
8.0% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@sinji2102 sinji2102 merged commit 1ad1262 into develop Dec 5, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ FEAT 기능 구현
Projects
Status: 🎉Done
Development

Successfully merging this pull request may close these issues.

[ Feat ] 예매자 관리 페이지 퍼블리싱
2 participants