[Feat/#404] presignedUrl 응답 타입 변경 #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR 작성하느라 고생 많았어요!! 라벨 잘 지정되었는지 확인 한 번 해 주기 🫶 |
|
ocahs9
approved these changes
Sep 13, 2024
Comment on lines
+15
to
+22
| export interface PresignedAllResponse { | ||
| status: number; | ||
| message: string; | ||
| data: { | ||
| performanceMakerPresignedUrls: PresignedResponse; | ||
| }; | ||
| } | ||
|
|
There was a problem hiding this comment.
p5) 깔끔하게 기존 타입 활용해서 잘 정의했네요 굿굿
| renderAfterTime: 5000, | ||
| renderAfterElementExists: "[data-testid='main-content']", | ||
| renderAfterTime: 500, |
There was a problem hiding this comment.
p5) prerenderer 관련된 설정인건 알겠는데, renderAfterTime을 임시로 5000이라고 설정했던 이유가 있었나요? 어떤 테스트를 해보려고 한건지 궁금해서 여쭤봅니다!
There was a problem hiding this comment.
엑 그거 단톡에서도 얘기했었는데
데이터를 자꾸 못가져와서 시간이 문제인가 싶어서 바꿔봤었어용
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈번호
🎟️ PR 유형
어떤 변경 사항이 있나요?
✅ Key Changes
📢 To Reviewers
📸 스크린샷
🔗 참고 자료