[Bug/#394] CSV 버그 수정 #395
Merged
[Bug/#394] CSV 버그 수정 #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR 작성하느라 고생 많았어요!! 라벨 잘 지정되었는지 확인 한 번 해 주기 🫶 |
|
imddoy
approved these changes
Sep 12, 2024
pepperdad
approved these changes
Sep 12, 2024
Comment on lines
+96
to
115
| const tempCSVDataArr: CSVDataType[] = []; | ||
|
|
||
| data.bookingList.map((item) => { | ||
| const date = item.createdAt.split("T")[0]; | ||
| const time = item.createdAt.split("T")[1].slice(0, 5); | ||
| const formattedDate = date?.replace(/-/g, "."); | ||
| const formattedCreateTime = `${formattedDate} ${time}`; | ||
|
|
||
| CSVDataArr.push({ | ||
| tempCSVDataArr.push({ | ||
| createdAt: formattedCreateTime, | ||
| scheduleNumber: `${convertingNumber(item.scheduleNumber)}회차`, | ||
| bookerName: item.bookerName, | ||
| purchaseTicketCount: `${item.purchaseTicketCount}매`, | ||
| bookerPhoneNumber: item.bookerPhoneNumber, | ||
| bookingStatus: convertingBookingStatus(item.bookingStatus), | ||
| }); | ||
|
|
||
| setCSVDataArr(tempCSVDataArr); | ||
| }); | ||
| } |
There was a problem hiding this comment.
p1
지금 코드 보면 tempCSVDataArr에 데이터를 추가하고, 반복문 안에서 계속 불필요하게 setCSVDataArr를 호출하고 있어!
tempCSVDataArr에 데이터를 모두 넣고, 반복문이 끝난 후에 한 번만 호출해도 될 것 같아!
이렇게 상태를 한 번에 업데이트하면 불필요한 상태 변경이 없어도 되서 무결성도 유지하면서, 성능도 더 괜찮을 것 같아!
아래 코드를 실행시켜 본 건 아닌데! 이런 식으로 하면 좋을 듯!
const tempCSVDataArr: CSVDataType[] = data.bookingList.map((item) => {
const date = item.createdAt.split("T")[0];
const time = item.createdAt.split("T")[1].slice(0, 5);
const formattedDate = date?.replace(/-/g, ".");
const formattedCreateTime = `${formattedDate} ${time}`;
return {
createdAt: formattedCreateTime,
scheduleNumber: `${convertingNumber(item.scheduleNumber)}회차`,
bookerName: item.bookerName,
purchaseTicketCount: `${item.purchaseTicketCount}매`,
bookerPhoneNumber: item.bookerPhoneNumber,
bookingStatus: convertingBookingStatus(item.bookingStatus),
};
});
setCSVDataArr(tempCSVDataArr);
There was a problem hiding this comment.
오 코드를 졸면서 짰나.. 좋은 지적 고마워 !!
바로 반영할게 👍
sinji2102
approved these changes
Sep 12, 2024
Comment on lines
+96
to
115
| const tempCSVDataArr: CSVDataType[] = []; | ||
|
|
||
| data.bookingList.map((item) => { | ||
| const date = item.createdAt.split("T")[0]; | ||
| const time = item.createdAt.split("T")[1].slice(0, 5); | ||
| const formattedDate = date?.replace(/-/g, "."); | ||
| const formattedCreateTime = `${formattedDate} ${time}`; | ||
|
|
||
| CSVDataArr.push({ | ||
| tempCSVDataArr.push({ | ||
| createdAt: formattedCreateTime, | ||
| scheduleNumber: `${convertingNumber(item.scheduleNumber)}회차`, | ||
| bookerName: item.bookerName, | ||
| purchaseTicketCount: `${item.purchaseTicketCount}매`, | ||
| bookerPhoneNumber: item.bookerPhoneNumber, | ||
| bookingStatus: convertingBookingStatus(item.bookingStatus), | ||
| }); | ||
|
|
||
| setCSVDataArr(tempCSVDataArr); | ||
| }); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈번호
🎟️ PR 유형
어떤 변경 사항이 있나요?
✅ Key Changes
📢 To Reviewers
📸 스크린샷
수정 전
수정 후
🔗 참고 자료