[Feat/#372] 예매 조회 페이지 취소 상태 추가 #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
PR 작성하느라 고생 많았어요!! 라벨 잘 지정되었는지 확인 한 번 해 주기 🫶 |
pepperdad
approved these changes
Aug 29, 2024
Comment on lines
34
to
40
| const bookingStatusText = { | ||
| CHECKING_PAYMENT: "입금 확인 예정", | ||
| BOOKING_CONFIRMED: "입금 완료", | ||
| BOOKING_CANCELLED: "예매 취소", | ||
| }; | ||
| type bookingStatusTypes = keyof typeof bookingStatusText; | ||
|
|
There was a problem hiding this comment.
p2) 이 부분은 관리 페이지나 다른 페이지에서도 공통적으로 사용될 수 있을 것 같아서 src/constant 아래에서 전역으로 사용할 수 있게 바꾸면 좋겠어용
아래의 아티클에서 그러면 enum 대신 어떤걸 쓰면 좋나요? 이 부분 읽어보시면 좋을 것 같아요!
https://velog.io/@hhhminme/%EB%84%A4-Enum-%EB%88%84%EA%B0%80-Typescript%EC%97%90%EC%84%9C-Enum%EC%9D%84-%EC%93%B0%EB%83%90
Comment on lines
4
to
6
| interface DefaultDepositPropTypes { | ||
| $status; | ||
| } |
There was a problem hiding this comment.
p3) 여기서도 타입 import 해서 추가해주세요!
|
imddoy
approved these changes
Aug 31, 2024
Comment on lines
+16
to
28
| {item.dueDate < 0 || item.bookingStatus === "BOOKING_CANCELLED" ? ( | ||
| <Button variant="line" disabled={true} size={{ width: "10.8rem", height: "3.6rem" }}> | ||
| 취소하기 | ||
| </Button> | ||
| ) : ( | ||
| <Button | ||
| variant="line" | ||
| size={{ width: "10.8rem", height: "3.6rem" }} | ||
| onClick={handleBtn} | ||
| > | ||
| 취소하기 | ||
| </Button> | ||
| ) : ( | ||
| <Button variant="line" disabled={true} size={{ width: "10.8rem", height: "3.6rem" }}> | ||
| 취소하기 | ||
| </Button> | ||
| )} |
There was a problem hiding this comment.
p5) 이 부분 중복 코드가 가독성을 떨어뜨리는 것 같습니다.
<Button
variant="line"
disabled={item.dueDate < 0 || item.bookingStatus === "BOOKING_CANCELLED"}
size={{ width: "10.8rem", height: "3.6rem" }}
onClick={handleBtn}
>
취소하기
</Button>이렇게 줄여보는건 어떤가용?
There was a problem hiding this comment.
좋아용
@sinji2102 신지 추후에 반영해주세용 ~
머지할게요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈번호
🎟️ PR 유형
어떤 변경 사항이 있나요?
✅ Key Changes
📢 To Reviewers
bookingStatusText관련해서 공통으로 빼는 게 더 좋을 것 같다는 코드리뷰가 있어 반영했습니다!! bookingStatus API 사용하는 페이지 있다면 저기서 사용하면 좋을 것 같아요~📸 스크린샷