Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/#367] maker UI 변경 #368

Merged
merged 3 commits into from
Aug 29, 2024
Merged

[Feat/#367] maker UI 변경 #368

merged 3 commits into from
Aug 29, 2024

Conversation

imddoy
Copy link
Contributor

@imddoy imddoy commented Aug 28, 2024

📌 관련 이슈번호

🎟️ PR 유형

어떤 변경 사항이 있나요?

  • 새 기능 추가
  • 버그 수정
  • CSS 등 사용자 UI 디자인 변경
  • 리팩토링

✅ Key Changes

이번 PR에서 작업한 내용을 간략히 설명해주세요

  1. 1:1로 사이즈 변경

📢 To Reviewers

  • 미리보기는 도영오빠 코드 사용해서 오빠 코드를 1:1로 변경했어요

📸 스크린샷

image

🔗 참고 자료

@github-actions github-actions bot added the ✨ FEAT 기능 구현 label Aug 28, 2024
Copy link

PR 작성하느라 고생 많았어요!! 라벨 잘 지정되었는지 확인 한 번 해 주기 🫶

Copy link

Copy link
Member

@pepperdad pepperdad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 키키 고생해써 ~

height: calc(15.7rem * 4 / 3);
height: 15.7rem;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5) 굿 키키

Copy link
Contributor

@sinji2102 sinji2102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM이야요

Comment on lines +288 to +291
useEffect(() => {
window.scrollTo({ top: 0 });
}, [registerStep]);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5) 레전드 섬세걸,,,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헤헤 꼬마와요

@imddoy imddoy merged commit f546977 into develop Aug 29, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ FEAT 기능 구현
Projects
Status: 🎉Done
Development

Successfully merging this pull request may close these issues.

[ Feat ] 메이커 UI 수정
3 participants