Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor/#359] 캐러셀 리팩토링 #360

Merged
merged 8 commits into from
Aug 30, 2024
Merged

[Refactor/#359] 캐러셀 리팩토링 #360

merged 8 commits into from
Aug 30, 2024

Conversation

sinji2102
Copy link
Contributor

📌 관련 이슈번호

🎟️ PR 유형

어떤 변경 사항이 있나요?

  • 새 기능 추가
  • 버그 수정
  • CSS 등 사용자 UI 디자인 변경
  • 리팩토링

✅ Key Changes

  1. 코드리뷰 반영 및 리팩토링

📢 To Reviewers

  • 슬라이드 현재 동작하지 않는데 코드 있는 게 안 좋은 것 같아서... 스프린트 다 반영하고 하려고 일단 제거해뒀습니다!
  • 상태 제외하고는 다 코드리뷰 반영했습니다.....!! 상태는 천천히 반영할게요 사실 하다가 stash 해뒀어요 키키
  • 반영한 코드리뷰들은 하단 PR 확인하면 됩니다!
    [!HOTFIX] 캐러셀 한 개 고정 + 외부 링크 이동

📸 스크린샷

@sinji2102 sinji2102 self-assigned this Aug 23, 2024
@sinji2102 sinji2102 linked an issue Aug 23, 2024 that may be closed by this pull request
[ Refactor ] 캐러셀 코드리뷰 반영 #359
Closed
3 tasks
@github-actions github-actions bot added 🚑 !HOTFIX 긴급한 수정(핫픽스) ♻️ REFACTOR 프로덕션 코드 리팩토링 labels Aug 23, 2024
@github-actions GitHub Actions
Copy link

PR 작성하느라 고생 많았어요!! 라벨 잘 지정되었는지 확인 한 번 해 주기 🫶

@sinji2102 sinji2102 removed the 🚑 !HOTFIX 긴급한 수정(핫픽스) label Aug 23, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

imddoy
imddoy approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@imddoy imddoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이전 코리들 잘 반영한 것 같아서 어푸합니당!

pepperdad
pepperdad approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@pepperdad pepperdad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했어요 ~
신지 고생했어!

ocahs9
ocahs9 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@ocahs9 ocahs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~ 더 깔끔해졌네요 굿굿

@sinji2102
Copy link
Contributor Author

너무 커다란 리팩토링이라서..... 😢 일단 머지하구 리팩토링 할게여 진심!!! 일단 스프린트 기간 안에 머지해야 할 것 같아서,,,

@sinji2102 sinji2102 merged commit c52a3fc into develop Aug 30, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocahs9 ocahs9 ocahs9 approved these changes

@imddoy imddoy imddoy approved these changes

@pepperdad pepperdad pepperdad approved these changes

Assignees

@sinji2102 sinji2102

Labels
♻️ REFACTOR 프로덕션 코드 리팩토링
Projects
🌱beat-board
Status: 🎉Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ Refactor ] 캐러셀 코드리뷰 반영
4 participants
@sinji2102 @pepperdad @imddoy @ocahs9