[Refactor/#352] 공연 및 스케쥴의 종료와 매진과 관련된 로직 서버에서 받아온 값으로 수정 #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR 작성하느라 고생 많았어요!! 라벨 잘 지정되었는지 확인 한 번 해 주기 🫶 |
|
sinji2102
approved these changes
Aug 21, 2024
| const lastPerformanceDate = new Date( | ||
| data.scheduleList[data?.scheduleList.length - 1].performanceDate | ||
| ); | ||
| const isBookingAvailable = data?.scheduleList[data?.scheduleList.length - 1]?.dueDate >= 0; |
There was a problem hiding this comment.
p5) 와웅 당신은 천재입니다...... 가독성 레전드 이렇게 하나씩 섬세한 게 레전드 개발자를 만들어주는 거군아....... 배우겟슴미다
|
|
||
| if (nowDate > lastPerformanceDate) { | ||
| if (!isBookingAvailable) { |
There was a problem hiding this comment.
p5) 레전드 섬세 뽀이... 확실히 메인으로 돌아가는 것보다 공연으로 돌아가는 게 좋을 것 같아요!!
imddoy
approved these changes
Aug 22, 2024
| const lastPerformanceDate = new Date( | ||
| data.scheduleList[data?.scheduleList.length - 1].performanceDate | ||
| ); | ||
| const isBookingAvailable = data?.scheduleList[data?.scheduleList.length - 1]?.dueDate >= 0; |
ocahs9
approved these changes
Aug 23, 2024
src/pages/gig/Gig.tsx
Outdated
| // 현재 시간이 마지막 공연 시간보다 크면 예매 버튼 비활성화 | ||
| const isBookDisabled = nowDate > lastPerformanceDate; | ||
| const isBookDisabled = data?.scheduleList[data?.scheduleList.length - 1]?.dueDate < 0; |
| const lastPerformanceDate = new Date( | ||
| data.scheduleList[data?.scheduleList.length - 1].performanceDate | ||
| ); | ||
| const isBookingAvailable = data?.scheduleList[data?.scheduleList.length - 1]?.dueDate >= 0; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈번호
🎟️ PR 유형
어떤 변경 사항이 있나요?
✅ Key Changes
기존의 클라이언트 측에서 new Date()로 설정했을 경우, 갤럭시 폰의 경우 시간을 바꿔서 악용할 수 있을 수 있었습니다.
이에 따라서 서버에서 받아온 데이터로 공연과 스케쥴의 종료 및 매진 여부를 정하도록 변경하였습니다.