Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Init/#33] Jotai 추가 #34

Merged
merged 2 commits into from
Jul 7, 2024
Merged

[Init/#33] Jotai 추가 #34

merged 2 commits into from
Jul 7, 2024

Conversation

pepperdad
Copy link
Member

📌 관련 이슈번호

🎟️ PR 유형

어떤 변경 사항이 있나요?

  • 새 기능 추가
  • 버그 수정
  • CSS 등 사용자 UI 디자인 변경
  • 리팩토링

✅ Key Changes

이번 PR에서 작업한 내용을 간략히 설명해주세요

  1. 전역상태 라이브러리 jotai 추가

📢 To Reviewers

  • 모달 컴포넌트에서 전역 상태로 관리하기 위해서 jotai 추가하였습니다.
  • PR 머지 전 사용하실 분들은 이 브랜치 pull 받아서 사용하시면 될 것 같습니다!

📸 스크린샷

🔗 참고 자료

@github-actions github-actions bot requested review from imddoy, ocahs9 and sinji2102 July 6, 2024 05:27
@github-actions github-actions bot added ✨ FEAT 기능 구현 🔧 INIT 초기 세팅 labels Jul 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 6, 2024

PR 작성하느라 고생 많았어요!! 라벨 잘 지정되었는지 확인 한 번 해 주기 🫶

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 6, 2024

🚀storybook: https://6687a84e56a8d673624b5d25-ambreaoknh.chromatic.com/

imddoy
imddoy approved these changes Jul 6, 2024
View reviewed changes
Copy link
Contributor

@imddoy imddoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

센스 굿~~~

sinji2102
sinji2102 approved these changes Jul 6, 2024
View reviewed changes
Copy link
Contributor

@sinji2102 sinji2102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿 제가 stores 폴더 추가하는 거 깜박햇는데 감사함미다

ocahs9
ocahs9 approved these changes Jul 6, 2024
View reviewed changes
Copy link
Contributor

@ocahs9 ocahs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 ~~ 👌

@pepperdad pepperdad merged commit 9533635 into develop Jul 7, 2024
10 checks passed
@sinji2102 sinji2102 deleted the init/#33/Jotai branch December 16, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinji2102 sinji2102 sinji2102 approved these changes

@imddoy imddoy imddoy approved these changes

@ocahs9 ocahs9 ocahs9 approved these changes

Assignees

@pepperdad pepperdad

Labels
✨ FEAT 기능 구현 🔧 INIT 초기 세팅
Projects
🌱beat-board
Status: 🎉Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ Init ] Jotai 라이브러리 추가
4 participants
@pepperdad @sinji2102 @imddoy @ocahs9