Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor/#30] 디자인시스템 업데이트 #31

Merged
merged 3 commits into from
Jul 6, 2024
Merged

[Refactor/#30] 디자인시스템 업데이트 #31

merged 3 commits into from
Jul 6, 2024

Conversation

imddoy
Copy link
Contributor

@imddoy imddoy commented Jul 5, 2024 •
edited
Loading

📌 관련 이슈번호

🎟️ PR 유형

어떤 변경 사항이 있나요?

  • 새 기능 추가
  • 버그 수정
  • CSS 등 사용자 UI 디자인 변경
  • 리팩토링

✅ Key Changes

이번 PR에서 작업한 내용을 간략히 설명해주세요

  1. 컬러 업데이트

📢 To Reviewers

  • gray_700 헥스코드 수정했고, 브랜드 컬러(토스 파랑, 카카오 노랑) 추가해서 pr올립니다!!
  • 폰트 추가 및 이름 수정했습니다. (-으로 연결)

+)

  • 소나클라우드가 중복코드 많다고 해서 fontGenerator를 theme으로 가져와서 수정 후, 함수로 폰트 적용시켰습니다!!

📸 스크린샷

🔗 참고 자료

@imddoy imddoy self-assigned this Jul 5, 2024
@github-actions github-actions bot added ♻️ REFACTOR 프로덕션 코드 리팩토링 ✨ FEAT 기능 구현 labels Jul 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

PR 작성하느라 고생 많았어요!! 라벨 잘 지정되었는지 확인 한 번 해 주기 🫶

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

🚀storybook: https://6687a84e56a8d673624b5d25-qtxirlbwif.chromatic.com/

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 6, 2024

🚀storybook: https://6687a84e56a8d673624b5d25-mydyiuazny.chromatic.com/

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 6, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 6, 2024

🚀storybook: https://6687a84e56a8d673624b5d25-xxwvwsaaey.chromatic.com/

@sinji2102 sinji2102 removed the ✨ FEAT 기능 구현 label Jul 6, 2024
sinji2102
sinji2102 approved these changes Jul 6, 2024
View reviewed changes
Copy link
Contributor

@sinji2102 sinji2102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인햇어욥 머지해두 될 듯!!! 고생 많았습니다~~ 소나클라우드가 쫌 싸가지 없는 경우가 잇어욥 별 것두 아닌 걸루 트집 잡구 ㅡㅡ

@imddoy imddoy merged commit cf7800a into develop Jul 6, 2024
5 checks passed
@sinji2102 sinji2102 deleted the refactor/#30/DesignSystemUpdate branch December 16, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinji2102 sinji2102 sinji2102 approved these changes

@ocahs9 ocahs9 Awaiting requested review from ocahs9

@pepperdad pepperdad Awaiting requested review from pepperdad

Assignees

@imddoy imddoy

Labels
♻️ REFACTOR 프로덕션 코드 리팩토링
Projects
🌱beat-board
Status: 🎉Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ Refactor ] 디자인시스템 컬러 업데이트
2 participants
@imddoy @sinji2102