Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix/#219] 로그인 시 유저정보 localStorage에 저장 안 되는 오류 수정 #220

Merged
merged 15 commits into from
Jul 18, 2024
Merged

[Fix/#219] 로그인 시 유저정보 localStorage에 저장 안 되는 오류 수정 #220

merged 15 commits into from
Jul 18, 2024

Conversation

sinji2102
Copy link
Contributor

📌 관련 이슈번호

🎟️ PR 유형

어떤 변경 사항이 있나요?

  • 새 기능 추가
  • 버그 수정
  • CSS 등 사용자 UI 디자인 변경
  • 리팩토링

✅ Key Changes

  • 로그인은 잘 됩니당 키키~~ 햄버거바에도 사용자 이름 연결했어요!!

📢 To Reviewers

  • 로그인 드디어 성공 ㅠㅠㅠㅠㅠㅠㅠㅠ 도영 오빠 고생했어............ 😢 진짜 고생맥스... 안 운 게 기적

pepperdad and others added 11 commits July 15, 2024 08:10
@pepperdad
feat: 배포시 발생하는 오류 없도록 변경
9492841
@pepperdad
fix: 빌드시 발생하는 오류 수정
d6e41d1
@pepperdad
Merge branch 'develop' of https://github.com/TEAM-BEAT/BEAT-Client
b831ca1 
; Please enter a commit message to explain why this merge is necessary,
; especially if it merges an updated upstream into a topic branch.
;
; Lines starting with ';' will be ignored, and an empty message aborts
; the commit.
@pepperdad
Merge branch 'develop' of https://github.com/TEAM-BEAT/BEAT-Client
e779bf3
@pepperdad
Merge branch 'develop' of https://github.com/TEAM-BEAT/BEAT-Client
9f2ce9c 
; Please enter a commit message to explain why this merge is necessary,
; especially if it merges an updated upstream into a topic branch.
;
; Lines starting with ';' will be ignored, and an empty message aborts
; the commit.
@pepperdad
fix: Register 페이지 타입 오류 수정
c4fdb9a
@pepperdad
Merge branch 'develop' of https://github.com/TEAM-BEAT/BEAT-Client
902ba33 
; Please enter a commit message to explain why this merge is necessary,
; especially if it merges an updated upstream into a topic branch.
;
; Lines starting with ';' will be ignored, and an empty message aborts
; the commit.
@pepperdad
Merge branch 'develop' of https://github.com/TEAM-BEAT/BEAT-Client
d2500d6
@pepperdad
Merge branch 'develop' of https://github.com/TEAM-BEAT/BEAT-Client
41c5827
@sinji2102
fix: 로그인 시 로컬스토리지에 사용자 정보 안 남는 오류 수정
81ebd2f
@sinji2102
feat: 햄버거바에 사용자 이름 연결되도록 수정
38ee76b
@sinji2102 sinji2102 linked an issue Jul 17, 2024 that may be closed by this pull request
[ Bug ] 로그인 시 유저정보 localStorage에 저장 안 되는 오류 수정 #219
Closed
2 tasks
@github-actions github-actions bot added the 🐛 BUG 버그를 고친 경우 label Jul 17, 2024
@github-actions GitHub Actions
Copy link

PR 작성하느라 고생 많았어요!! 라벨 잘 지정되었는지 확인 한 번 해 주기 🫶

@github-actions github-actions bot requested review from imddoy, ocahs9 and pepperdad July 17, 2024 19:50
pepperdad
pepperdad approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@pepperdad pepperdad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최고 머지하세요.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sinji2102 sinji2102 merged commit 5baf696 into develop Jul 18, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepperdad pepperdad pepperdad approved these changes

@imddoy imddoy Awaiting requested review from imddoy

@ocahs9 ocahs9 Awaiting requested review from ocahs9

Assignees

@sinji2102 sinji2102

Labels
🐛 BUG 버그를 고친 경우
Projects
🌱beat-board
Status: 🎉Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ Bug ] 로그인 시 유저정보 localStorage에 저장 안 되는 오류 수정
2 participants
@sinji2102 @pepperdad