Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Init/#7] 디자인시스템 초기세팅 #20

Merged
merged 16 commits into from
Jul 5, 2024
Merged

Conversation

imddoy
Copy link
Contributor

@imddoy imddoy commented Jul 3, 2024

📌 관련 이슈번호

🎟️ PR 유형

어떤 변경 사항이 있나요?

  • 새 기능 추가
  • 버그 수정
  • CSS 등 사용자 UI 디자인 변경
  • 리팩토링

✅ Key Changes

이번 PR에서 작업한 내용을 간략히 설명해주세요

  1. 컬러 및 폰트 세팅
  2. 제너레이터 세팅
    • flex, font
  3. 모바일 뷰 세팅

📢 To Reviewers

  • import { Generators } from "../../styles/generator";로 임포트해서 ${Generators.flexGenerator("row", "center", "center")};처럼 사용해주세요. 더 필요한 설정 있으면 말씀해주세요! 바로 넣겠습니다.
  • 경로가 너무 더러워서 alias 설정하려고 했는데 모듈로 인식해서 일단 그냥 상대경로로 import해왔습니다.

📸 스크린샷

image

잘 적용되는지 확인했습니다.

🔗 참고 자료

@github-actions github-actions bot added the ✨ FEAT 기능 구현 label Jul 3, 2024
Copy link

github-actions bot commented Jul 3, 2024

PR 작성하느라 고생 많았어요!! 라벨 잘 지정되었는지 확인 한 번 해 주기 🫶

@github-actions github-actions bot added the 🔧 INIT 초기 세팅 label Jul 3, 2024
Copy link
Member

@pepperdad pepperdad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니당 ~
타입 인식하도록 제가 추가해놨고, bg 색 관련 코멘트만 확인해주시면 될 것 같아요!

채현이 최고 !!!!!

margin: 0 auto;
overflow-x: hidden;

background-color: ${({ theme }) => theme.colors.pink_400};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5) 혹시 bg 색은 일부러 핑크로 해놓으신 건가요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 해놓고 다시 안돌려놨네용....수정하겠습니다ㅎㅎ

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
p3) 타입 인식하도록 제가 추가해놨어요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다!

Copy link

sonarqubecloud bot commented Jul 4, 2024

Copy link
Member

@pepperdad pepperdad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨씁니다 :)

Copy link
Contributor

@sinji2102 sinji2102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

허거덩 제가 폴더구조 초기세팅 하면서 놓친 부분까지!!! 감사빤스... 🫶 최고예요

@pepperdad pepperdad merged commit 2788d8c into develop Jul 5, 2024
3 checks passed
@sinji2102 sinji2102 deleted the init/#7/DesignSystem branch December 16, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ FEAT 기능 구현 🔧 INIT 초기 세팅
Projects
Status: 🎉Done
Development

Successfully merging this pull request may close these issues.

[ Init ] 디자인시스템 초기세팅
3 participants