-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Init/#7] 디자인시스템 초기세팅 #20
Conversation
PR 작성하느라 고생 많았어요!! 라벨 잘 지정되었는지 확인 한 번 해 주기 🫶 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니당 ~
타입 인식하도록 제가 추가해놨고, bg 색 관련 코멘트만 확인해주시면 될 것 같아요!
채현이 최고 !!!!!
src/styles/global.ts
Outdated
margin: 0 auto; | ||
overflow-x: hidden; | ||
|
||
background-color: ${({ theme }) => theme.colors.pink_400}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p5) 혹시 bg 색은 일부러 핑크로 해놓으신 건가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 해놓고 다시 안돌려놨네용....수정하겠습니다ㅎㅎ
src/styles/styled.d.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
감사합니다!
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨씁니다 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
허거덩 제가 폴더구조 초기세팅 하면서 놓친 부분까지!!! 감사빤스... 🫶 최고예요
📌 관련 이슈번호
🎟️ PR 유형
어떤 변경 사항이 있나요?
✅ Key Changes
📢 To Reviewers
import { Generators } from "../../styles/generator";
로 임포트해서${Generators.flexGenerator("row", "center", "center")};
처럼 사용해주세요. 더 필요한 설정 있으면 말씀해주세요! 바로 넣겠습니다.📸 스크린샷
잘 적용되는지 확인했습니다.
🔗 참고 자료