[Feat/#104] 메인 페이지 추가 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
|
PR 작성하느라 고생 많았어요!! 라벨 잘 지정되었는지 확인 한 번 해 주기 🫶 |
imddoy
approved these changes
Jul 12, 2024
Comment on lines
+24
to
+26
| <Chip | ||
| key={`performance-${i}`} | ||
| label={item.label} |
There was a problem hiding this comment.
p5) 아까 막 열심히 하는 것 같더니 이거였구만용
Comment on lines
+25
to
+27
| performanceId: 2, | ||
| performanceTitle: "정도영 댄스 공연", | ||
| performancePeriod: "2023.12.29~2023.12.30", |
There was a problem hiding this comment.
p100) 우왕 저도 보고 싶어요! 더 열어주세요
There was a problem hiding this comment.
p5) 으어 이거 나 공연 등록하기에서 장르 선택때랑 겹쳐보이는디 small이랑 large차이없으면 하나로 합칠 수 있나?? 차이 있나?
svgr-generate.cjs
Outdated
There was a problem hiding this comment.
p5) 이거 혹시 문제있을까봐 안올리고 있었는데 올려도 되려나...?
There was a problem hiding this comment.
헉 안 되나...?? 도영 오빠 당근 끝나면 물어보께욥
ocahs9
approved these changes
Jul 14, 2024
Comment on lines
+13
to
+20
| scrollbar-width: none; | ||
| -ms-overflow-style: none; | ||
|
|
||
| &::-webkit-scrollbar { | ||
| display: none; | ||
| } | ||
| white-space: nowrap; | ||
| `; |
pepperdad
approved these changes
Jul 14, 2024
| return ( | ||
| <S.ChipWrapper color={color} onClick={onClick}> | ||
| {icon && <S.ChipIcon>{icon}</S.ChipIcon>} | ||
| {icon && <S.ChipIcon iconColor={iconColor}>{icon}</S.ChipIcon>} |
| import styled from "styled-components"; | ||
|
|
||
| export const MainWrapper = styled.section` | ||
| width: auto; |
There was a problem hiding this comment.
제 맘인데요? 농담이고... wrapper로 항상 감싸고 시작하는데 아무 옵션도 안 주면 오류 나서 줬어욥
Comment on lines
+25
to
+27
| performanceId: 2, | ||
| performanceTitle: "정도영 댄스 공연", | ||
| performancePeriod: "2023.12.29~2023.12.30", |
src/pages/main/constants/chipList.ts
Outdated
| import { IconSmallMusical, IconSmallBand, IconSmallDance, IconSmallEtc } from "@assets/svgs"; | ||
|
|
||
| export const CHIP_LIST = [ | ||
| // { label: "전체", genre: "ALL" }, |
There was a problem hiding this comment.
p1) p1 으로 달아보고 싶었음. 삭제 부탁드려용!
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈번호
🎟️ PR 유형
어떤 변경 사항이 있나요?
✅ Key Changes
📢 To Reviewers
📸 스크린샷