[Feat/#85] 공연 등록 완료 페이지 구현 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR 작성하느라 고생 많았어요!! 라벨 잘 지정되었는지 확인 한 번 해 주기 🫶 |
pepperdad
approved these changes
Jul 11, 2024
| const RegisterComplete = () => { | ||
| const user = "메이커"; | ||
| const navigate = useNavigate(); | ||
| const goGigsPage = () => navigate(`/gig/${REGISTER_RESPONSE.performanceId}`); |
There was a problem hiding this comment.
p4) 이 부분은 추후에 등록하는 페이지에서 state로 값 넘겨받을 수 있또록 해주세요!
There was a problem hiding this comment.
p5) 저도 도영님 말씀이 좋은 것 같습니다 ~ state 관리 필요할 것 같아요 !
Comment on lines
18
to
22
| <Lottie | ||
| animationData={registerComplete} | ||
| play={true} | ||
| style={{ width: "150px", height: "150px", margin: "0 auto" }} | ||
| /> |
There was a problem hiding this comment.
p5) 굿 ~~ 지금은 무한 루프로 되어있는데, 제가 봤을 때는 한 번만 실행되는 게 좋아보여요!
loop=false 만 추가하면 되니까 디자이너랑 얘기해보면 좋을 것 같아요!
There was a problem hiding this comment.
p5) 저도 한번만 딱 진행되는게 더 예뻐보이긴 하네요~ 확정되었다고 하니까 수정 고고
pepperdad
reviewed
Jul 11, 2024
sinji2102
approved these changes
Jul 12, 2024
ocahs9
approved these changes
Jul 12, 2024
| const RegisterComplete = () => { | ||
| const user = "메이커"; | ||
| const navigate = useNavigate(); | ||
| const goGigsPage = () => navigate(`/gig/${REGISTER_RESPONSE.performanceId}`); |
There was a problem hiding this comment.
p5) 저도 도영님 말씀이 좋은 것 같습니다 ~ state 관리 필요할 것 같아요 !
Comment on lines
18
to
22
| <Lottie | ||
| animationData={registerComplete} | ||
| play={true} | ||
| style={{ width: "150px", height: "150px", margin: "0 auto" }} | ||
| /> |
There was a problem hiding this comment.
p5) 저도 한번만 딱 진행되는게 더 예뻐보이긴 하네요~ 확정되었다고 하니까 수정 고고
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈번호
🎟️ PR 유형
어떤 변경 사항이 있나요?
✅ Key Changes
📢 To Reviewers
📸 스크린샷
2024-07-11.081655.mp4
🔗 참고 자료