Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Feat/#79 ] eye input 추가 구현 #100

Merged
merged 3 commits into from
Jul 12, 2024
Merged

[ Feat/#79 ] eye input 추가 구현 #100

merged 3 commits into from
Jul 12, 2024

Conversation

imddoy
Copy link
Contributor

@imddoy imddoy commented Jul 10, 2024

📌 관련 이슈번호

🎟️ PR 유형

어떤 변경 사항이 있나요?

  • 새 기능 추가
  • 버그 수정
  • CSS 등 사용자 UI 디자인 변경
  • 리팩토링

✅ Key Changes

이번 PR에서 작업한 내용을 간략히 설명해주세요

  1. isPasswordVisible에 따라서 비밀번호가 보이게 안보이게 구현

📢 To Reviewers

  • props 막 넘겨줬는데 괜찮을까요....
  • type에 password로 주면 눈 아이콘 나오고 type 따로 지정 안하면 input으로 x아이콘 나옵니다

📸 스크린샷

image image

🔗 참고 자료

Copy link

PR 작성하느라 고생 많았어요!! 라벨 잘 지정되었는지 확인 한 번 해 주기 🫶

@github-actions github-actions bot added the ✨ FEAT 기능 구현 label Jul 10, 2024
Copy link

Copy link
Member

@pepperdad pepperdad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sinji2102 sinji2102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조아요잉 🫶 어푸하께욥

@imddoy imddoy merged commit c00db8c into develop Jul 12, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ FEAT 기능 구현
Projects
Status: 🎉Done
Development

Successfully merging this pull request may close these issues.

[ Feat ] eye input 컴포넌트 추가
3 participants