[A26][Stella] Adds support for the console Select switch #4178
+54
−38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to implement this, some arguments from
stella_frame_advance()
had to be condensed.To keep things consistent, I combined together all of the switches that belong to the same memory register. The power switch remains separate. Like the Reset switch, the Select switch defaults to a high (1) state, and when pressed becomes low (0).
Since the waterboxed core already had a function for changing the TV color switch, I also added partial handling for that. But it will still have to be hooked up on the BizHawk side (in Stella.IEmulator.cs) in order for BizHawk to be capable of switching it. For now, it's always set to the Color (1) state.
I've tested to confirm all of the inputs (both controllers and console switches) are working as intended.
Resolves #4175
Check if completed: