Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A26][Stella] Adds support for the console Select switch #4178

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bigbass1997
Copy link

In order to implement this, some arguments from stella_frame_advance() had to be condensed.

To keep things consistent, I combined together all of the switches that belong to the same memory register. The power switch remains separate. Like the Reset switch, the Select switch defaults to a high (1) state, and when pressed becomes low (0).

Since the waterboxed core already had a function for changing the TV color switch, I also added partial handling for that. But it will still have to be hooked up on the BizHawk side (in Stella.IEmulator.cs) in order for BizHawk to be capable of switching it. For now, it's always set to the Color (1) state.

I've tested to confirm all of the inputs (both controllers and console switches) are working as intended.

Resolves #4175

Check if completed:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[A26][Stella] Select switch is not implemented
1 participant