Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A26][Stella] Select switch is not implemented #4175

Open
bigbass1997 opened this issue Jan 8, 2025 · 0 comments · May be fixed by #4178
Open

[A26][Stella] Select switch is not implemented #4175

bigbass1997 opened this issue Jan 8, 2025 · 0 comments · May be fixed by #4178

Comments

@bigbass1997
Copy link

Summary

The "Select" input doesn't do anything while using the new Stella core. This input corresponds to the Select switch on the console itself, akin to the reset switch.

Upon reviewing the code, it appears the input was never hooked into Stella? Stella's Switches class doesn't even provide a function for setting this switch's state oddly enough. However, according to this section of code the internal mySwitches variable does appear to contain a bit for the select switch state.

Having this input is pretty critical. I suspect adding a Switches::setSelect(bool) function on Stella's side, and then hooking into it in here and here would be sufficient? Seems that's what was done to support the reset switch.

Repro

  1. Set preferred A26 core to Stella.
  2. Load any Atari 2600 rom that makes use of the select switch.
    • Video Chess for example uses it to select the difficulty mode (represented by the number 1-8 at the top of the board).
    • Paul Slocum's "Testcart" test rom is also a good option.
  3. Try pressing the Select switch using any input method (controller/keyboard, virtual pad, or TAStudio).

Host env.

  • BizHawk 2.10; Linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants