-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Review content of crossenv to respect build vs cross. #6437
base: master
Are you sure you want to change the base?
Conversation
@th0ma7 I was hoping this would fix numpy for python312, but it doen't (still getting |
@hgy59 thnx for testing but it's not ready yet, I've only laid-down the foundation to have a reusable requirement mk file. I still have to:
Only once that is complete I should be ready to start looking further into |
@hgy59 still a bit of testing todo but I should be iches away from being ready to look in particular at the I'll let things run but changes done so far in this PR to the |
hey @th0ma7, looking forward to this PR. Looking at the build errors it seems that based on this python-greenlet/greenlet#392 (comment), they are caused by:
As such, I believe if you comment out this line your build should succeed:
|
I believe it is now complete and ready for testing. Only remaining item (unless github-action tells me otherwise): |
Suggested plan of actions:
Thoughts? |
@th0ma7 I have updated the comment in python-wheels packages related to the include of spksrc.python.mk. Please feel free to revert it, if it is not correct... |
@th0ma7 one thing I am missing when building single wheels with I guess we only need to add something like |
Python 3.13.2 is already released. EDIT: |
Yeah, I thought of that too. By default it gest collected when invoking a full standard build but not for neither crossenv-* or wheel-*. I can look into that. I wonder, would it make sense to have a per-wheel log in a sub-directory? or having a single wheel-arch-version.log and similarly a crossenv-arch-version.log created? maybe even only when invoking them directly (not sure i can do that)? That I'd add to this PR. |
Great work, @th0ma7! You might consider re-enabling |
For me, a single build-wheel-arch-version.log was enough. no need for wheel-name or -version in the log file name |
- add llfuse to python312-wheels and python313-wheels - use -std=gnu11 for gcc < 5
Bah, i would have rather having the separated due to the already lengthy pr, but fine by me. |
- llfuse wheel fails to build with python313
llfuse fails to build for python313:
|
I alredy reported an issue with octoprint and python312 On this branch I found another issue.
I already have seen other wheels with |
Another open question: Do we really need the In python312-wheels we only have
Both come from the regular So my guess is, that the wheel build can autodetect the abi. |
Thnx for further testing its exactly the type of feedback i need. I have a good idea of the reason, I'll look at it in the coming days. Pretty sure the issue is with how the crossenv is being built using manylinux which now impact pure python wheels which previously were built using native |
Description
Review content of crossenv to respect build vs cross.
Closes #6430
Checklist
all-supported
completed successfullyType of change