Don't download a new binary if one is already present. #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, nice work, can you please fix CS and tests |
|
Yep, sorry about that. |
There was a problem hiding this comment.
I think we need to tweak the docs as well: https://symfony.com/bundles/TailwindBundle/current/index.html#using-a-different-binary-version
sbrow
force-pushed
the
sbrow-patch-1
branch
2 times, most recently
from
bac7dc7 to
24c8321
Compare
|
Thanks for more changes, I still think we need to tweak the docs as well: https://symfony.com/bundles/TailwindBundle/current/index.html#using-a-different-binary-version To make it clear about the process of finding the binary, WDYT? |
|
@bocharsky-bw My apologies. I did not realize that the docs were in the same repository as the plugin. I've done my best to explain the changes, but feel free to make edits as needed 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #84, if a user has not configured a binary version, but has already downloaded an outdated tailwind binary, the outdated version will be used instead of downloading a new version.
This prevents builds from breaking when users unexpectedly are upgraded from v3.x to v4.
I could add a message that warns users they are not using the most up-to-date version, if necessary.