Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BehatBridge] Create & Update page #152

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Dec 10, 2024

No description provided.

@loic425 loic425 marked this pull request as draft December 10, 2024 07:42
@loic425 loic425 changed the title Update page [BehatBridge] Update page - not ready Dec 10, 2024
@loic425 loic425 marked this pull request as ready for review January 20, 2025 11:27
@loic425 loic425 changed the title [BehatBridge] Update page - not ready [BehatBridge] Create & Update page Jan 20, 2025
features/admin/book/managing_books/adding_books.feature Outdated Show resolved Hide resolved
src/BehatBridge/config/services/behat/element/admin.php Outdated Show resolved Hide resolved
protected function getDefinedElements(): array
{
return [
'create_button' => '[type=submit]:contains("Create")',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need data-test attribute for this as well?

tests/Behat/Context/Domain/BookContext.php Show resolved Hide resolved
behat.dist.yaml Outdated Show resolved Hide resolved
tests/Behat/Page/Admin/Book/CreatePage.php Show resolved Hide resolved
tests/Behat/Page/Admin/Book/UpdatePage.php Show resolved Hide resolved
tests/Behat/Page/Admin/Book/UpdatePage.php Show resolved Hide resolved
@loic425 loic425 force-pushed the update-page branch 2 times, most recently from d250854 to a8e0dbe Compare January 20, 2025 19:10
@loic425 loic425 merged commit 8f93122 into Sylius:behat-bridge Jan 21, 2025
6 checks passed
@loic425 loic425 deleted the update-page branch January 21, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants