Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add transaction id to payment details #252

Merged
merged 2 commits into from
Jul 14, 2022

Conversation

PILLOWPET
Copy link

Q A
Branch? 1.3 (security fixes), 1.4 (bug fixes, improvements), master (new features)
Bug fix? no
New feature? yes
Related tickets mentioned in #251

@Zales0123 Zales0123 changed the base branch from master to 1.4 July 14, 2022 10:19
@Zales0123 Zales0123 force-pushed the add-transaction-id-to-payment-details branch from 1ca3b68 to cda8150 Compare July 14, 2022 10:19
@Zales0123
Copy link
Member

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "add-transaction-id-to-payment-details" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@Zales0123
Copy link
Member

Zales0123 commented Jul 14, 2022

Hello @PILLOWPET 🖖 I've allowed myself to rebase it and add a basic spec for the new functionality (there was no spec for the class at all 😱 definitely needs to be fixed). I've also added a check if the gathered value is set, to prevent from potential failures.

Thank you for your contribution! 🚀

@Zales0123 Zales0123 merged commit 8529e65 into Sylius:1.4 Jul 14, 2022
@Zales0123
Copy link
Member

Thanks, Hadrien! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants