fix: amaltheasessions need rbac to delete secrets #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is part of the following stack: Change managed by git-spice. |
olevski
force-pushed
the
fix-add-secret-rbac
branch
from
2e2c07e to
9697d75
Compare
olevski
force-pushed
the
fix-add-secret-rbac
branch
2 times, most recently
from
2d3f257 to
612f253
Compare
Without this the amalthea sessions controller cannot cleanup adopted secrets.
olevski
force-pushed
the
fix-amalthea-session-port
branch
from
04aef78 to
c7fa91a
Compare
olevski
force-pushed
the
fix-add-secret-rbac
branch
from
612f253 to
c4feccc
Compare
sgaist
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.