Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: additional status updates for AmaltheaSessions #609

Merged
merged 19 commits into from
Jul 5, 2024

Conversation

olevski
Copy link
Member

@olevski olevski commented Jul 2, 2024

closes #608

The only thing missing from the status now is the idleness check. But we should resolve that in the hibernation task.

Depends on #605

@olevski olevski requested review from ableuler and a team as code owners July 2, 2024 21:20
@olevski olevski mentioned this pull request Jul 3, 2024
@olevski olevski requested a review from sgaist July 4, 2024 14:01
internal/controller/children.go Outdated Show resolved Hide resolved
internal/controller/children.go Outdated Show resolved Hide resolved
internal/controller/status.go Outdated Show resolved Hide resolved
@olevski olevski requested a review from sgaist July 5, 2024 09:27
Copy link
Collaborator

@sgaist sgaist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olevski olevski enabled auto-merge (squash) July 5, 2024 09:39
@olevski olevski merged commit 255a120 into main Jul 5, 2024
17 checks passed
@olevski olevski deleted the feat-status-complete branch July 5, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session status update
2 participants