Reading \" in free text variables #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is assumed with wrong encoding and special characters appear later
…columns in test for new variable mnplang
…closure character with backslash
|
Wow... great job @DrEspresso! Thanks a lot! |
|
despite failure on ubuntu, merging... |
aghaynes
merged commit a6b38f9
into
SwissClinicalTrialOrganisation:master
8 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix to issues #220 and #261 :
read_export_options()now also reads enclosure character from header.print.secuTrialoptions()now also prints enclosure character. Quote and Tabulator are now printed as'\"'and'\t'rather than'"'and' '.read_export_table()now usesreadr::read_delim()with optionsescape_backslash = TRUEandquote = export_options$quoteOther changes:
read_export_table()toread_secuTrial_raw()(one warning per export file instead of several warnings for each table)read_export_options()now reads only the first 10 lines to find the encoding. Reading all lines would fail if the export options were ISO-8859 encoded and contained 'problematic' characaters, e.g. in center names.encodingoption inplot_recruitment(): Not needed here, as centres are read with correct encoding inread_secuTrial_raw()and stored in the secuTrialR object.