fix: Preserve type members of namespace in re-exported module #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we would generate `declare const …: typeof …` which declares an object with the same value members but none of the type members. Fixes Swatinem#322. Signed-off-by: Anders Kaseorg <[email protected]>
andersk
added a commit
to andersk/rspack
that referenced
this pull request
Oct 31, 2024
Swatinem/rollup-plugin-dts#323 Fixes web-infra-dev#8277. Signed-off-by: Anders Kaseorg <[email protected]>
2 tasks
Swatinem
approved these changes
Oct 31, 2024
chenjiahan
pushed a commit
to web-infra-dev/rspack
that referenced
this pull request
Nov 1, 2024
Swatinem/rollup-plugin-dts#323 Fixes #8277. Signed-off-by: Anders Kaseorg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would generate
declare const …: typeof …which declares an object with the same value members but none of the type members.