Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force emit types even when there're errors #320

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix: force emit types even when there're errors #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,9 @@ const plugin: PluginImpl<Options> = (options = {}) => {
},
undefined, // cancellationToken
true, // emitOnlyDtsFiles
undefined, // customTransformers
// @ts-ignore This is a private API for workers, should be safe to use as TypeScript Playground has used it for a long time.
true, // forceDtsEmit
);
if (emitSkipped) {
const errors = diagnostics.filter((diag) => diag.category === ts.DiagnosticCategory.Error);
Expand Down
3 changes: 3 additions & 0 deletions tests/testcases/using-ts-files/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
export interface A {}
export interface B {}
export interface unused {}
// The following code triggers `Unused '@ts-expect-error' directive` error,
// but it doesn't actually prevent the DTS from being emitted.
// @ts-expect-error