Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create program for imports input file #318 #319

Merged
merged 2 commits into from
Oct 23, 2024
Merged

fix: create program for imports input file #318 #319

merged 2 commits into from
Oct 23, 2024

Conversation

NWYLZW
Copy link
Contributor

@NWYLZW NWYLZW commented Oct 19, 2024

No description provided.

Swatinem
Swatinem approved these changes Oct 19, 2024
View reviewed changes
Copy link
Owner

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to have a testcase for this as well

@NWYLZW
Copy link
Contributor Author

NWYLZW commented Oct 20, 2024

would be nice to have a testcase for this as well

I also want to write a test case. However, it seems that currently the fixture does not support declare impoets by package. After failing to write a unit test, I gave up. Do you have any good ideas or suggestions?

@Swatinem Swatinem merged commit e74fb86 into Swatinem:master Oct 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swatinem Swatinem Swatinem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NWYLZW @Swatinem