Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to display the version as a footnote #90

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

Tibimac
Copy link

@Tibimac Tibimac commented Sep 22, 2024

I thought this could be an interesting little addition, that's why I added it.
Feel free to make the changes you seem necessary.

@SvenTiigi SvenTiigi changed the base branch from main to develop October 9, 2024 19:15
@SvenTiigi
Copy link
Owner

Hi @Tibimac,

Thanks for your PR! 👍

Adding a footer / footnote below the buttons is a great idea.
However, in my opinion the implementation should be more flexible to support various views, not only a version number, as use cases may vary.

What do you think?

@Tibimac
Copy link
Author

Tibimac commented Oct 10, 2024

@SvenTiigi if you have other cases in mind feel free to adjust the implementation for more various cases, now or later. It may be interesting to add this use case now and add more flexibility in a future addition. WDYT ?

@SvenTiigi SvenTiigi changed the base branch from develop to feature/footer October 10, 2024 10:53
@SvenTiigi
Copy link
Owner

Merged in feature/footer branch

@SvenTiigi SvenTiigi merged commit d5361bb into SvenTiigi:feature/footer Oct 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants