Mobile test submission - Enzo Lizama #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshaw-mgm
reviewed
Oct 12, 2021
There was a problem hiding this comment.
Great work. I really like the very good cli and all of the packages used. The superformula splash screen is a great touch 😅 . The problem with the very good cli template is that it leaves a lot of code that may not be used. I left a few comments, questions and suggestions.
Thanks for the submission!
mattsolle
reviewed
Oct 12, 2021
There was a problem hiding this comment.
Hi @enzoftware, thank you for completing the code challenge! It was a pleasure looking over it. Fantastic job overall. I have left a few comments, questions, suggestions, and bugs. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.