check always if reader dirty

SuaveIO · Sep 20, 2024 · 445fec8 · 445fec8
1 parent 34607b6
commit 445fec8
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/src/Suave/ConnectionFacade.fs b/src/Suave/ConnectionFacade.fs
@@ -322,8 +322,7 @@ type ConnectionFacade(connection: Connection, runtime: HttpRuntime, connectionPo
         | Result.Error e ->
           flag := false
           result := Result.Error e
-      reader.stop()
-      return result
+      return result.Value
       }
 
   member this.accept(binding) = task{
@@ -334,13 +333,15 @@ type ConnectionFacade(connection: Connection, runtime: HttpRuntime, connectionPo
     connection.socketBinding <- binding
     try
       let task = Task.Factory.StartNew(reader.readLoop,cancellationToken)
-      let! a = this.requestLoop()
-      ()
+      match! this.requestLoop() with
+      | Ok () -> ()
+      | Result.Error err ->
+        do Console.WriteLine(sprintf "Error: %A" err)
     with
       | ex ->
-        if reader.isDirty then
-          reader.stop()
         do Console.WriteLine("Error: " + ex.Message)
+    if reader.isDirty then
+          reader.stop()
     Interlocked.Decrement(Globals.numberOfClients) |> ignore
     if Globals.verbose then
       do Console.WriteLine("Disconnected {0}. {1} connected.", clientIp,(!Globals.numberOfClients))