Refactor script preloading #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhoebeMitchell
force-pushed
the
bugfix/216-Script-preloading-ignores-stitches-2
branch
from
f0b6ab6 to
e344ba4
Compare
PhoebeMitchell
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #505 +/- ##
===========================================
+ Coverage 86.27% 87.80% +1.53%
===========================================
Files 93 95 +2
Lines 3169 3214 +45
===========================================
+ Hits 2734 2822 +88
+ Misses 435 392 -43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Copilot reviewed 6 out of 13 changed files in this pull request and generated 1 suggestion.
Files not reviewed (7)
- unity-ggjj/Assets/Resources/InkDialogueScripts/CaseDemo/2-1-FullScene.ink: Language not supported
- unity-ggjj/Assets/Scenes/Game.unity: Language not supported
- unity-ggjj/Assets/Scripts/NarrativeScript/MissingBackgroundTagException.cs.meta: Language not supported
- unity-ggjj/Assets/Scripts/NarrativeScript/StoryData.cs.meta: Language not supported
- unity-ggjj/Assets/Scripts/NarrativeScript/NarrativeScriptPlayer/NarrativeScriptPlayer.cs: Evaluated as low risk
- unity-ggjj/Assets/Scripts/GameState/ChoiceExtensions.cs: Evaluated as low risk
- unity-ggjj/Assets/Scripts/GameState/InvestigationState.cs: Evaluated as low risk
unity-ggjj/Assets/Scripts/NarrativeScript/MissingBackgroundTagException.cs
Outdated
Show resolved
Hide resolved
ViMaSter
approved these changes
Nov 19, 2024
unity-ggjj/Assets/Scripts/NarrativeScript/MissingBackgroundTagException.cs
Outdated
Show resolved
Hide resolved
…Exception.cs Co-authored-by: Vincent Mahnke <[email protected]>
Co-authored-by: Vincent Mahnke <[email protected]>
ViMaSter
approved these changes
Nov 20, 2024
PhoebeMitchell
deleted the
bugfix/216-Script-preloading-ignores-stitches-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors narrative script preloading, allowing for:
Testing instructions
Does the game still work?