Skipping dialogue no longer plays any sound and ends the entire line

[IsaacLaquerre]

Summary

See #372

Testing instructions

See #372

Additional information

• [ ] Changes UI
• [ ] Introduces new feature
• [ ] Removes existing feature
• [X] Has associated resource:
  • Closes [BUG] Dialogue skipping SFX & visual issue #372

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.39%. Comparing base (d33749a) to head (9cfd72a).
Report is 93 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #373      +/-   ##
===========================================
+ Coverage    78.35%   78.39%   +0.03%     
===========================================
  Files           85       85              
  Lines         2943     2948       +5     
===========================================
+ Hits          2306     2311       +5     
  Misses         637      637              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[PhoebeMitchell]

Great to have another contributor, and a really simple change!
Though I hate to be like this because it's your first PR and all, but I'm a little confused. Isn't the original implementation closer to how it worked in the Lua build?

[IsaacLaquerre]

Great to have another contributor, and a really simple change! Though I hate to be like this because it's your first PR and all, but I'm a little confused. Isn't the original implementation closer to how it worked in the Lua build?

as far as i remember in the Lua build, i made it so when you hold X, it wouldn't loop the speech SFX until the end of the sentence and would completely display the sentence (as most visual novel games do). feel free to reach out if you think we should revert back to how the letters were displayed 1 by 1 :)

[PhoebeMitchell]

Closing as discussed in the issue
#390