Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.2.1 #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

V0.2.1 #25

wants to merge 2 commits into from

Conversation

oscarpeters
Copy link

Readability update to schematics

  • Changed schematic size to A4
  • Changed schematic to hierarchical schematics
  • Schematic layout update
  • Added LCSC BOM to Racer hardware

- Schematic readability improvements.
- Changed schematic symbols.
- Changed to hierarchical schematic.
- Added LCSC BOM for the available components.
Updated Schematics to hierarchical, Schematic size to A4.
@andistorm
Copy link
Collaborator

andistorm commented Nov 4, 2024

Hey @oscarpeters,

thanks for coming up with this PR. I really appreciate your work.

Unfortunately it is very hard to review it, because you put a lot of changes in this.

Could you split up your PR in multiple ones, please? Each PR as small as possible (one feature/bugfix per PR).

Then I would be happy to review your work.

Cheers 🐧

@andistorm
Copy link
Collaborator

Regarding to your changes (at least partially):

In this case the project ist not that complex that a hierachical schematics is really necessary. I would say the advantage of having all on one page is bigger.

Maybe you could add images or a PDF of the individually parts and add them to a new directory.

Maybe racer:docs/images/
Than you could add furthermore some markdown explanation if you would like.

I assume you wanted to make it easier to understand for new people this is why I suggest to convert it to documentation.

@fschrempf
Copy link
Contributor

In this case the project ist not that complex that a hierachical schematics is really necessary. I would say the advantage of having all on one page is bigger.

I agree. I also like it better on a single page as long as everything fits in nicely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants