Skip to content

Commit

Permalink
Removing v1 & v2 references in the contribution guidances
Browse files Browse the repository at this point in the history
  • Loading branch information
michaelmaillot committed Apr 4, 2023
1 parent dbcea83 commit 5201c8b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 19 deletions.
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ fixes #X, mentioned in #Y
*You can delete this section when you are submitting the pull request.*

* Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.
* Please target your PR to "version-3" branch for v3 changes, "version-2" branch for v2 changes and "version-1" branch for v1 changes
* Please target your PR to "version-3" branch for v3 changes
* Please ensure you have updated any associated docs files based on your code changes
* Please ensure you have updated/added tests to cover your change.
* If you are fixing a bug include a test that would have caught the bug you are fixing
Expand Down
18 changes: 0 additions & 18 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,4 @@
* If you are fixing a bug, include a test that would have caught the bug you are fixing
* Ensure tslint checks pass by typing `npm run lint`
* Keep your PRs as simple as possible and describe the changes to help the reviewer understand your work
* If you have an idea for a larger change to the library please [open an issue](https://github.com/pnp/pnpjs/issues) and let's discuss before you invest many hours - these are very welcome but want to ensure it is something we can merge before you spend the time :)

## Contributing Guidance - v2

* Target your pull requests to the **version-2** branch
* Add/Update any docs articles related to your changes
* Include a test for any new functionality and ensure all existing tests are passing by running `npm test`
* If you are fixing a bug, include a test that would have caught the bug you are fixing
* Ensure tslint checks pass by typing `npm run lint`
* Keep your PRs as simple as possible and describe the changes to help the reviewer understand your work
* If you have an idea for a larger change to the library please [open an issue](https://github.com/pnp/pnpjs/issues) and let's discuss before you invest many hours - these are very welcome but want to ensure it is something we can merge before you spend the time :)


## Contributing Guidance - v1

* Target your pull requests to the **version-1** branch
* Ensure tslint checks pass by typing `gulp lint`
* Keep your PRs as simple as possible and describe the changes to help the reviewer understand your work
* If you have an idea for a larger change to the library please [open an issue](https://github.com/pnp/pnpjs/issues) and let's discuss before you invest many hours - these are very welcome but want to ensure it is something we can merge before you spend the time :)

0 comments on commit 5201c8b

Please sign in to comment.