Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Avoid loading meta schema unnecessarily #697

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Conversation

Stranger6667
Copy link
Owner

No description provided.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.61%. Comparing base (b2754fd) to head (d716eef).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
crates/jsonschema-referencing/src/registry.rs 92.85% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #697   +/-   ##
=======================================
  Coverage   85.61%   85.61%           
=======================================
  Files          92       92           
  Lines       14400    14408    +8     
=======================================
+ Hits        12328    12335    +7     
- Misses       2072     2073    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Feb 5, 2025

CodSpeed Performance Report

Merging #697 will improve performances by 49.47%

Comparing dd/skip-meta (d716eef) with master (b2754fd)

Summary

⚡ 9 improvements
✅ 36 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
try_new[draft 2019-09] 36.6 µs 27.3 µs +34.03%
try_new[draft 2020-12] 37.3 µs 28 µs +33.43%
try_new[draft 4] 34.7 µs 25.7 µs +35.07%
try_new[draft 6] 36.2 µs 26.6 µs +35.73%
try_new[draft 7] 38.3 µs 28.9 µs +32.87%
try_with_resource[CITM] 51.1 µs 36.6 µs +39.71%
try_with_resource[Fast] 35.1 µs 23.5 µs +49.47%
try_with_resource[GeoJSON] 83.8 µs 64.5 µs +29.99%
try_with_resource[Open API] 240.2 µs 207.2 µs +15.94%

@Stranger6667 Stranger6667 merged commit 802fcb6 into master Feb 5, 2025
38 of 39 checks passed
@Stranger6667 Stranger6667 deleted the dd/skip-meta branch February 5, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant