Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ValidationOptions::with_registry #685

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Stranger6667
Copy link
Owner

@Stranger6667 Stranger6667 commented Jan 31, 2025

Resolves #682

TODO: use try_with_resources

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.47%. Comparing base (e1fb6fe) to head (b05aa6a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #685      +/-   ##
==========================================
+ Coverage   85.42%   85.47%   +0.04%     
==========================================
  Files          90       90              
  Lines       14137    14167      +30     
==========================================
+ Hits        12077    12109      +32     
+ Misses       2060     2058       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 31, 2025

CodSpeed Performance Report

Merging #685 will not alter performance

Comparing dd/registry-update (b05aa6a) with master (e1fb6fe)

Summary

✅ 45 untouched benchmarks

@Stranger6667 Stranger6667 marked this pull request as draft January 31, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a ValidationOptions::with_registry method
1 participant