Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolving external references nested inside local references #672

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

Stranger6667
Copy link
Owner

Fixes #671

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 96.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.48%. Comparing base (29b37f0) to head (1444b41).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
crates/jsonschema/src/keywords/ref_.rs 93.75% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #672      +/-   ##
==========================================
+ Coverage   85.43%   85.48%   +0.04%     
==========================================
  Files          90       90              
  Lines       14038    14072      +34     
==========================================
+ Hits        11994    12029      +35     
+ Misses       2044     2043       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Dmitry Dygalo <[email protected]>
Copy link

codspeed-hq bot commented Jan 22, 2025

CodSpeed Performance Report

Merging #672 will degrade performances by 12%

Comparing dd/fix-external-in-local (1444b41) with master (29b37f0)

Summary

❌ 1 (👁 1) regressions
✅ 44 untouched benchmarks

Benchmarks breakdown

Benchmark master dd/fix-external-in-local Change
👁 try_with_resource[Swagger] 1.7 ms 1.9 ms -12%

@Stranger6667 Stranger6667 merged commit 210eebb into master Jan 22, 2025
37 checks passed
@Stranger6667 Stranger6667 deleted the dd/fix-external-in-local branch January 22, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrieving external reference in a deeply nested subschema
1 participant