Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Extend ValidationErrorKind with error-specific context #656

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

Stranger6667
Copy link
Owner

try:
    jsonschema_rs.validate({"maxItems": 2}, [1,2,3])
except Exception as exc:
    error = exc

print(a.kind.limit)
# 2

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 2.18579% with 179 lines in your changes missing coverage. Please review.

Project coverage is 85.31%. Comparing base (fb652cd) to head (d0a0935).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
crates/jsonschema-py/src/lib.rs 0.00% 179 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
- Coverage   86.15%   85.31%   -0.84%     
==========================================
  Files          90       90              
  Lines       13647    13786     +139     
==========================================
+ Hits        11757    11761       +4     
- Misses       1890     2025     +135     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 24, 2024

CodSpeed Performance Report

Merging #656 will not alter performance

Comparing dd/more-error-context (d0a0935) with master (cfd6702)

Summary

✅ 45 untouched benchmarks

@Stranger6667 Stranger6667 force-pushed the dd/more-error-context branch 4 times, most recently from 36c21a7 to 45b3170 Compare December 24, 2024 15:16
@Stranger6667 Stranger6667 merged commit 4806e5c into master Dec 24, 2024
38 checks passed
@Stranger6667 Stranger6667 deleted the dd/more-error-context branch December 24, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant